[PATCH] D111410: [InstCombine] generalize fold for mask-with-signbit-splat

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 8 10:06:19 PDT 2021


RKSimon accepted this revision.
RKSimon added a comment.

LGTM

> So I think this patch makes things more consistent. But if the more specific transform was here as a work-around, we could leave it in as a special-case before we do the more general fold (...but that would be pretty hacky).

Maybe remove the current fold as a followup commit to make bisection a little easier if somebody was depending upon it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111410/new/

https://reviews.llvm.org/D111410



More information about the llvm-commits mailing list