[PATCH] D111308: [flang][driver] Add actions that execute despite semantic errors

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added inline comments.


================
Comment at: flang/lib/Frontend/FrontendActions.cpp:45
+  // Semantic checks are made to succeed unconditionally.
+  return RunPrescan() & RunParse() && (RunSemanticChecks() || true);
+}
----------------
PeteSteinfeld wrote:
> awarzynski wrote:
> > MatsPetersson wrote:
> > > Probably should fix the & to && in this one too, following the suggestion from FIR-Dev.
> > For our future selves: https://github.com/flang-compiler/f18-llvm-project/pull/1113#discussion_r724321121
> Note that this line of code is also modified by https://reviews.llvm.org/D111395.  Should these patches be combined?
https://reviews.llvm.org/D111395 fixes a bug on L40, so it's a different line.

This patch creates `PrescanAndSemaDebugAction`. It will work correctly without modifying `PrescanAndSemaAction`. https://reviews.llvm.org/D111395 fixes the latter, but that does not affect the former.

As the two changes are unrelated, I think that it's worthwhile to keep them in separate commits. This way it will be easier to track down the rationale for the fix. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111308/new/

https://reviews.llvm.org/D111308