[PATCH] D111308: [flang][driver] Add actions that execute despite semantic errors
Pete Steinfeld via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 8 06:22:15 PDT 2021
PeteSteinfeld added inline comments.
================
Comment at: flang/lib/Frontend/FrontendActions.cpp:45
+ // Semantic checks are made to succeed unconditionally.
+ return RunPrescan() & RunParse() && (RunSemanticChecks() || true);
+}
----------------
awarzynski wrote:
> MatsPetersson wrote:
> > Probably should fix the & to && in this one too, following the suggestion from FIR-Dev.
> For our future selves: https://github.com/flang-compiler/f18-llvm-project/pull/1113#discussion_r724321121
Note that this line of code is also modified by https://reviews.llvm.org/D111395. Should these patches be combined?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111308/new/
https://reviews.llvm.org/D111308
More information about the llvm-commits
mailing list