[PATCH] D110630: [DebugInfo][InstrRef] Use PHI placement utilities for variable-value calculations

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 8 04:24:40 PDT 2021


jmorse updated this revision to Diff 378163.
jmorse added a comment.

Update for review comments, labelled all the block numbers with names, adjusted comments, and deleted some now unused variables.

I've also switched the "BlockNo" field of class DbgValue to being an int rather than unsigned: MachineBasicBlock::getNumber returns a signed int, so it makes sense to store something as close to that as possible.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110630/new/

https://reviews.llvm.org/D110630

Files:
  llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
  llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
  llvm/test/DebugInfo/MIR/InstrRef/pick-vphi-in-shifting-loop.mir
  llvm/unittests/CodeGen/InstrRefLDVTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110630.378163.patch
Type: text/x-patch
Size: 139079 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211008/5140b1a6/attachment-0001.bin>


More information about the llvm-commits mailing list