[PATCH] D110630: [DebugInfo][InstrRef] Use PHI placement utilities for variable-value calculations

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added a comment.

First pass look through looks fine to me, some minor nits inline but the overall function seems correct.



================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:1983
 
-    assert(OutVal.Kind == DbgValue::Proposed || OutVal.Kind == DbgValue::Def);
-    ValueIDNum ValToLookFor = OutVal.ID;
+    // If the live-in value in a def, find the locations where that value is
+    // present. Do the same for VPHIs where we know the VPHI value.
----------------



================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:2151
+    if (Bail || Values.size() == 0) {
+      DbgValueProperties EmptyProperties(EmptyExpr, false);
+      ConfirmValue(Var, OldLiveInDbgValue);
----------------
Unused variable? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110630/new/

https://reviews.llvm.org/D110630