[PATCH] D111294: [LoopVectorize] Fix crash in VPReplicateRecipe::execute() for scalable vectors

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 8 00:53:38 PDT 2021


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:5136
+      else
+        PossibleNonScalarPtrs.insert(Update);
+
----------------
Hm, with this change we might miss some cases where the uses of `Update` are still scalar. Would it be better to only return early here if the only user of the update instruction is the pointer phi and let the code below handle the other cases?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111294/new/

https://reviews.llvm.org/D111294



More information about the llvm-commits mailing list