[PATCH] D111294: [LoopVectorize] Fix crash in VPReplicateRecipe::execute() for scalable vectors

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

I think it would be good to update the title to better reflect the change here. From the title it sounds like a change in `VPReplicateRecipe::execute() `, but it actually adjusts how pointers are classified  which as a side-effect fixes a crash.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:5132
+
+      if (llvm::all_of(Update->users(),
+                       [&](User *U) { return isa<PHINode>(U); }))
----------------
nit: `'llvm::` should not be needed. Can you also add comment here to explain the reasoning?

Also, no need to capture everything in the lambda.


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-widen-gep.ll:166
+end:
+  ret i64 undef
+}
----------------
just return void?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111294/new/

https://reviews.llvm.org/D111294