[PATCH] D111268: [lld][test] Fix darwin REQUIRES (NFC)

[Vincent Lee via Phabricator via llvm-commits]

thevinster accepted this revision.
thevinster added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/test/MachO/search-paths-darwin.test:2
 REQUIRES: x86
-REQUIRES: darwin
+REQUIRES: system-darwin
 
----------------
keith wrote:
> thevinster wrote:
> > What's the reason for not supporting `darwin` in LLD's lit config instead? If compiler-rt defines the feature, then it makes sense for LLD to follow a similar pattern. 
> Since there are more uses of `system-darwin` across the whole project, and that configuration is centralized, that feels to me like a better one to standardize on. I think if we want to make this more clear for folks we should probably remove the custom ones from compiler-rt instead
That's fair. Fwiw, it's not just compiler-rt. A quick search showed libcxx defining the `darwin` feature as well, but it does look like the majority continues to use `system-darwin`. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111268/new/

https://reviews.llvm.org/D111268