[PATCH] D111268: [lld][test] Fix darwin REQUIRES (NFC)

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 7 07:56:14 PDT 2021


keith added inline comments.


================
Comment at: lld/test/MachO/search-paths-darwin.test:2
 REQUIRES: x86
-REQUIRES: darwin
+REQUIRES: system-darwin
 
----------------
thevinster wrote:
> What's the reason for not supporting `darwin` in LLD's lit config instead? If compiler-rt defines the feature, then it makes sense for LLD to follow a similar pattern. 
Since there are more uses of `system-darwin` across the whole project, and that configuration is centralized, that feels to me like a better one to standardize on. I think if we want to make this more clear for folks we should probably remove the custom ones from compiler-rt instead


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111268/new/

https://reviews.llvm.org/D111268



More information about the llvm-commits mailing list