[PATCH] D111122: [NFC][llvm-reduce] Cleanup types

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 7 11:19:08 PDT 2021


aeubanks updated this revision to Diff 377920.
aeubanks added a comment.

undo comment reformatting
we should never have a null Module, added asserts for that and changed the constructor to force an initial Module
I prefer Module& to show that it can never be null


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111122/new/

https://reviews.llvm.org/D111122

Files:
  llvm/tools/llvm-reduce/TestRunner.cpp
  llvm/tools/llvm-reduce/TestRunner.h
  llvm/tools/llvm-reduce/deltas/Delta.cpp
  llvm/tools/llvm-reduce/deltas/Delta.h
  llvm/tools/llvm-reduce/deltas/ReduceAliases.cpp
  llvm/tools/llvm-reduce/deltas/ReduceArguments.cpp
  llvm/tools/llvm-reduce/deltas/ReduceAttributes.cpp
  llvm/tools/llvm-reduce/deltas/ReduceBasicBlocks.cpp
  llvm/tools/llvm-reduce/deltas/ReduceFunctionBodies.cpp
  llvm/tools/llvm-reduce/deltas/ReduceFunctions.cpp
  llvm/tools/llvm-reduce/deltas/ReduceGlobalValues.cpp
  llvm/tools/llvm-reduce/deltas/ReduceGlobalVarInitializers.cpp
  llvm/tools/llvm-reduce/deltas/ReduceGlobalVars.cpp
  llvm/tools/llvm-reduce/deltas/ReduceInstructions.cpp
  llvm/tools/llvm-reduce/deltas/ReduceMetadata.cpp
  llvm/tools/llvm-reduce/deltas/ReduceModuleData.cpp
  llvm/tools/llvm-reduce/deltas/ReduceOperandBundles.cpp
  llvm/tools/llvm-reduce/deltas/ReduceOperands.cpp
  llvm/tools/llvm-reduce/deltas/ReduceSpecialGlobals.cpp
  llvm/tools/llvm-reduce/llvm-reduce.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111122.377920.patch
Type: text/x-patch
Size: 31322 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211007/636b110e/attachment.bin>


More information about the llvm-commits mailing list