[PATCH] D111122: [NFC][llvm-reduce] Cleanup types
Michael Kruse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 6 20:59:32 PDT 2021
Meinersbur added a comment.
`std::vector<Chunk>` -> `Oracle`: LGTM
`Module*` -> `Module&`: It's a code style question and I prefer using `Module*` (or wrapped in a smart pointer) consistently. I don't like that sometimes it's `M.` but sometimes `M->`. It also makes "Has TestRunner been assigned a Program yet?" undefined behaviour.
There are some comment reflows. I assume this is due to adding a new scope, clang-format, removing the scope, clang-format again. Could you clean that up?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111122/new/
https://reviews.llvm.org/D111122
More information about the llvm-commits
mailing list