[PATCH] D111198: [Support] Make consumeError, toString callable from code compiled with RTTI.

Thu Oct 7 11:04:12 PDT 2021

v.g.vassilev added a comment.

In D111198#3044293 <https://reviews.llvm.org/D111198#3044293>, @lhames wrote:

> Vassil -- This is a generalization of the error fix that we discussed. Could you double check that it fixes the linker error that you saw?
>
> After thinking about it for a while I'm on the fence about this approach -- on the one hand it's a reasonable cleanup, on the other hand I don't think we generally support linking -no-rtti LLVM libraries from -rtti code, and support for doing that (even partial support) might be an explicit non-goal for the project.
>
> Another approach to fixing the example might just be to split it into two files. Pros of that approach: it deals with no-rtti/rtti crossover code The Right Way, Con: it complicates the example for everyone else.

@lhames, thanks a lot for the patch -- this makes D107049 <https://reviews.llvm.org/D107049> compile. I do not have a strong opinion on how/should we bridge rtti/no-rtti. I feel this will come up more often due to clang-repl...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111198/new/

https://reviews.llvm.org/D111198