[PATCH] D111198: [Support] Make consumeError, toString callable from code compiled with RTTI.

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 5 17:33:19 PDT 2021


lhames added a comment.

Vassil -- This is a generalization of the error fix that we discussed. Could you double check that it fixes the linker error that you saw?

After thinking about it for a while I'm on the fence about this approach -- on the one hand it's a reasonable cleanup, on the other hand I don't think we generally support linking -no-rtti LLVM libraries from -rtti code, and support for doing that (even partial support) might be an explicit non-goal for the project.

Another approach to fixing the example might just be to split it into two files. Pros of that approach: it deals with no-rtti/rtti crossover code The Right Way, Con: it complicates the example for everyone else.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111198/new/

https://reviews.llvm.org/D111198



More information about the llvm-commits mailing list