[PATCH] D108872: [IR] Refactor GlobalIFunc to inherit from GlobalObject, Remove GlobalIndirectSymbol

[Itay Bookstein via Phabricator via llvm-commits]

ibookstein added inline comments.


================
Comment at: llvm/docs/LangRef.rst:910
 
-    @<Name> = [Linkage] [Visibility] ifunc <IFuncTy>, <ResolverTy>* @<Resolver>
+    @<Name> = [Linkage] [PreemptionSpecifier] [Visibility] ifunc <IFuncTy>, <ResolverTy>* @<Resolver>
 
----------------
MaskRay wrote:
> Drop the change?
> 
> An ifunc definition can be interposed/preempted.
The change only documents the existing situation, though, as far as I can tell.
There are tests which check/specify a [PreemptionSpecifier]; If I remember correctly, if you'd drop the PrintDSOLocation/maybeSetDSOLocal you'd get test failures.
I searched for "dso_local ifunc" and got some hits from the tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108872/new/

https://reviews.llvm.org/D108872