[PATCH] D108872: [IR] Refactor GlobalIFunc to inherit from GlobalObject, Remove GlobalIndirectSymbol

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 7 09:13:18 PDT 2021


MaskRay added a comment.

> The current behavior of GlobalValue::getBaseObject is inconsistent. For example, calling getBaseObject on a GlobalAlias whose Aliasee

This description needs update after renaming of `getBaseObject`.



================
Comment at: llvm/docs/LangRef.rst:910
 
-    @<Name> = [Linkage] [Visibility] ifunc <IFuncTy>, <ResolverTy>* @<Resolver>
+    @<Name> = [Linkage] [PreemptionSpecifier] [Visibility] ifunc <IFuncTy>, <ResolverTy>* @<Resolver>
 
----------------
Drop the change?

An ifunc definition can be interposed/preempted.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108872/new/

https://reviews.llvm.org/D108872



More information about the llvm-commits mailing list