[PATCH] D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/include/llvm/Support/Debuginfod.h:10
+namespace llvm {
+namespace debuginfod {
+
----------------
phosek wrote:
> We usually avoid nested namespace, I don't think in this case it should be necessary.
To clarify, I don't think this should be in namespace `debuginfod`, it should be in namespace `llvm`.


================
Comment at: llvm/include/llvm/Support/HTTPClient.h:25
+
+namespace http {
+struct Response {
----------------
The same here, this should be in namespace `llvm`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111252/new/

https://reviews.llvm.org/D111252