[PATCH] D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool

Noah Shutty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 7 10:23:40 PDT 2021


noajshu added inline comments.


================
Comment at: llvm/test/tools/llvm-debuginfod/find-test.sh:1
+set -x
+
----------------
phosek wrote:
> Using shell for this test makes it non-portable across platforms (for example there may not be any shell on Windows) so I think we'll need a different approach.
Good point! We could replace shell with Python. Python's `subprocess` module is used elsewhere in the tests (e.g. `./llvm/test/tools/llvm-symbolizer/Inputs/flush-output.py`)
Let me know if there's a better way to orchestrate (I can also ask around).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111252/new/

https://reviews.llvm.org/D111252



More information about the llvm-commits mailing list