[PATCH] D110167: [Dexter] Add option to pass a Visual Studio solution instead of a binary

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer updated this revision to Diff 377894.
StephenTozer added a comment.

The previous version of the patch made use of the existing `_loading_error` field in a way that was inconsistent with existing code; existing uses have been fixed up so that the field is used consistently.

In short summary, the field was assigned inconsistent value types - on initialization it is assigned an exception object directly, in all other assignments it is either None or the value of `sys.exc_info()`. This patch assigned an exception directly, consistent with the initial value, but it appears as though the initial assignment was never actually used (and would cause an error if it was). Also, while we would assign `self._loading_error = sys.exc_info()` when we encountered an error when initializing or entering the debugger, we only used the loading error during initialization, not afterwards (making the second assignment meaningless as well).

The fix for this is to set the value to `None` initially instead of a never-used exception object, and use the `loading_error` property consistently between initializing and entering the debugger.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110167/new/

https://reviews.llvm.org/D110167

Files:
  cross-project-tests/debuginfo-tests/dexter/dex/builder/ParserOptions.py
  cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerBase.py
  cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/DebuggerControllerBase.py
  cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
  cross-project-tests/debuginfo-tests/dexter/dex/tools/TestToolBase.py
  cross-project-tests/debuginfo-tests/dexter/dex/tools/run_debugger_internal_/Tool.py
  cross-project-tests/debuginfo-tests/dexter/dex/tools/test/Tool.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110167.377894.patch
Type: text/x-patch
Size: 8637 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211007/34debe13/attachment.bin>