[PATCH] D110167: [Dexter] Add option to pass a Visual Studio solution instead of a binary

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added inline comments.


================
Comment at: cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/DebuggerControllerBase.py:24-27
+            if self.debugger.init_success:
+                self._run_debugger_custom()
+            else:
+                raise Exception(self.debugger.loading_error)
----------------
StephenTozer wrote:
> Orlando wrote:
> > Is this (and the necessity for the new `init_success` attribute) a bug-fix? 
> The current error handling approach seems somewhat unmaintained - it's hard to say whether this qualifies as a "bug fix" or just implementing error handling for the behaviour in this specific patch.
What happens without this patch if the vs solution cannot be created (i.e. when `_custom_init` raises `LoadDebuggerException`)? I'm just trying to understand the impact of this part of the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110167/new/

https://reviews.llvm.org/D110167