[PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 7 01:31:16 PDT 2021


labath added a comment.

In D110535#3047262 <https://reviews.llvm.org/D110535#3047262>, @mgorny wrote:

> In D110535#3047033 <https://reviews.llvm.org/D110535#3047033>, @joerg wrote:
>
>> Can't you wrap `iterator_range<T>` and possibly even support Twines like that? That is, don't extend the life time of the iterators, but store it in the range?
>
> I can but @labath didn't want the extra code.

I am not sure that it is worth it, but I am not completely opposed to the idea either. Symmetry with StringRef::split also counts for something..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110535/new/

https://reviews.llvm.org/D110535



More information about the llvm-commits mailing list