[PATCH] D109837: cmake: Remove config.guess

[Harald van Dijk via Phabricator via llvm-commits]

hvdijk added a comment.

In D109837#3035161 <https://reviews.llvm.org/D109837#3035161>, @tstellar wrote:

> I tested this and it doesn't work.  If we normalize x86_64-redhat-linux to x86_64-redhat-linux-gnu, then we don't end up picking the gcc install at /usr/lib/gcc/x86_64-redhat-linux/.

We actually already don't. Red Hat have a RH-specific patch for this that lets it work, it's not related to the triple handling, it's that RH prefer GCC installations that contain libgcc_s, which RH's cross-compilers don't: https://src.fedoraproject.org/rpms/clang/blob/rawhide/f/0004-PATCH-clang-Prefer-gcc-toolchains-with-libgcc_s.so-w.patch And this is suppressed under `-static -static-libgcc`, so to confirm that this is what causes the GCC installation to be picked that you want: after installing gcc-x86_64-linux-gnu and clang on a Fedora system, `clang -v` prints "Selected GCC installation: /usr/bin/../lib/gcc/x86_64-redhat-linux/11", `clang -static -static-libgcc -v` prints "Selected GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/11".

So, this patch, if we modify it to normalize x86_64-redhat-linux to x86_64-redhat-linux-gnu, does not make things any worse. I am not trying to dismiss your other patches, they should still be considered, just probably not as blockers for this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109837/new/

https://reviews.llvm.org/D109837