[PATCH] D110905: [llvm] Add overload to propagate errors up to caller from ExpandResponseFiles

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D110905#3046352 <https://reviews.llvm.org/D110905#3046352>, @oontvoo wrote:

> Withdrawing this . With some deliberation, I've realised this patch is actually doing the wrong thing . Specifically, the expansion here happens too early that it shouldn't know yet if it would really be an error if `@foo` is not a file ... it could have meant to be some  variable(, eg `-rpath @loader_path`)
>
> The fix I'm hoping to make can be done in lld-macho . (it also should have had a test that fails because of this patch).
>
> Thanks for entertaining this!

OK, thanks for the discussion!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110905/new/

https://reviews.llvm.org/D110905