[PATCH] D111227: [WebAssembly] Implementation of table.grow/size and ref.null intrinsics

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

In D111227#3046124 <https://reviews.llvm.org/D111227#3046124>, @pmatos wrote:

> In D111227#3045475 <https://reviews.llvm.org/D111227#3045475>, @sbc100 wrote:
>
>> Could we bypass/delay a lot of this complexity by specifying the initial version of intrinsic for `table.grow` as "grow_table_with_null"  .. then we don't need `ref.null` intrinsic or these new types?  (at least not yet).
>
> If the motivation is to delay the complexity, then just having `grow_table_with_null` wouldn't suffice because we would still need the new types to define the `table.size` and `table.grow` param types. I also worry that doing something half-baked now will come to haunt us later if we then do it "properly" and have to keep old intrinsics for the sake of backwards compatibility.

Isn't "got with null" likely to be by far the most likely thing to be used?    I'm tempted to call that `__table_grow` and go with `__table_grow_with_default_elem` for the less-used one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111227/new/

https://reviews.llvm.org/D111227