[PATCH] D111227: [WebAssembly] Implementation of table.grow/size and ref.null intrinsics

Paulo Matos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 6 11:30:37 PDT 2021


pmatos added a comment.

In D111227#3045475 <https://reviews.llvm.org/D111227#3045475>, @sbc100 wrote:

> Could we bypass/delay a lot of this complexity by specifying the initial version of intrinsic for `table.grow` as "grow_table_with_null"  .. then we don't need `ref.null` intrinsic or these new types?  (at least not yet).

If the motivation is to delay the complexity, then just having `grow_table_with_null` wouldn't suffice because we would still need the new types to define the `table.size` and `table.grow` param types. I also worry that doing something half-baked now will come to haunt us later if we then do it "properly" and have to keep old intrinsics for the sake of backwards compatibility.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111227/new/

https://reviews.llvm.org/D111227



More information about the llvm-commits mailing list