[PATCH] D110579: [AMDGPU] Add two new intrinsics to control fp_trunc rounding mode

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 6 06:00:32 PDT 2021


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIModeRegister.cpp:420
+//  s_round_mode 0x0
+void SIModeRegister::selectSRoundModePseudos(MachineBasicBlock &MBB,
+                                       const SIInstrInfo *TII) {
----------------
You shouldn't need to add a new pass here to insert s_round_mode instructions. The SIModeRegister pass already knows how to do that. You should just be able to add your new PSEUDOs to the switch in getInstructionMode.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110579/new/

https://reviews.llvm.org/D110579



More information about the llvm-commits mailing list