[PATCH] D110839: [LNT] Refactoring of cPerf

[Dmitry Vassiliev via Phabricator via llvm-commits]

slydiman added inline comments.


================
Comment at: lnt/testing/profile/profile.py:34-36
+                                  binaryCacheRoot = os.getenv('LNT_BINARY_CACHE_ROOT', ''),
+                                  nm = os.getenv('CMAKE_NM', 'nm'),
+                                  objdump = os.getenv('CMAKE_OBJDUMP', 'objdump'))
----------------
thopre wrote:
> This will set the parameters to None (and thus override the default values of the parameter) when the environment variables are not set. I don't think this is what you meant.
```
import os

def prn(x):
    print(x)

prn(x = os.getenv('MISSING_VAR', 'abc'))
```
Output: abc
What am I missing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110839/new/

https://reviews.llvm.org/D110839