[PATCH] D110839: [LNT] Refactoring of cPerf

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D110839#3042769 <https://reviews.llvm.org/D110839#3042769>, @kpdev42 wrote:

> @thopre Should I rework this patch somehow?

I think ideally the bullet points in your patch description should each correspond to a different patch. That said, I don't have sufficient expertise to review everything but I might be able to review some of the resulting patches.



================
Comment at: lnt/testing/profile/profile.py:34-36
+                                  binaryCacheRoot = os.getenv('LNT_BINARY_CACHE_ROOT', ''),
+                                  nm = os.getenv('CMAKE_NM', 'nm'),
+                                  objdump = os.getenv('CMAKE_OBJDUMP', 'objdump'))
----------------
This will set the parameters to None (and thus override the default values of the parameter) when the environment variables are not set. I don't think this is what you meant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110839/new/

https://reviews.llvm.org/D110839