[PATCH] D111201: [GlobalISel] Clear unreachable blocks' contents after selection.
Mikael Holmén via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 6 01:31:40 PDT 2021
uabelho added inline comments.
================
Comment at: llvm/lib/CodeGen/GlobalISel/InstructionSelect.cpp:217
+ // Don't delete the block in case the block has it's address taken or is
+ // still being referenced by a phi somewhere.
+ continue;
----------------
What happens if the unreachable block defines a value %val that is used in the phi? Will it be handled some way or lead to a verifier error? (I don't know this code at all so perhaps it's totally obvious it will just work out nicely.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111201/new/
https://reviews.llvm.org/D111201
More information about the llvm-commits
mailing list