[PATCH] D111072: [llvm-cxxfilt][NFC] Fix test for running in Windows cmd

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

In D111072#3042597 <https://reviews.llvm.org/D111072#3042597>, @hans wrote:

> In D111072#3042430 <https://reviews.llvm.org/D111072#3042430>, @probinson wrote:
>
>> Is there a config tweak needed to get this to run properly for us?  Given the upstream Windows bots are not seeing a problem.
>
> I'm guessing the upstream bots get their "echo" from msys/Git. In Chromium we use "echo" etc. from GnuWin, and that's what I have locally too.

My "bad" echo is from GnuWin too. Testing locally it looks like the echo shipped with git for Windows handles unicode without an issue.

> Maybe the best fix would be to make lit's internal "echo" work both in the pipe and redirect-to-file cases? That way we'd reduce our reliance on external tools, which seems like a good thing.

I'm not very familiar with `llvm-lit` internals and am unsure if there's a reason this wasn't done before. I've mentioned this on llvm-dev (subject `[llvm-dev][llvm-lit] Old echo causes test failure on windows`) to get others' thoughts on the topic too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111072/new/

https://reviews.llvm.org/D111072