[PATCH] D111072: [llvm-cxxfilt][NFC] Fix test for running in Windows cmd
Hans Wennborg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 5 06:37:22 PDT 2021
hans added a comment.
In D111072#3042430 <https://reviews.llvm.org/D111072#3042430>, @probinson wrote:
> Is there a config tweak needed to get this to run properly for us? Given the upstream Windows bots are not seeing a problem.
I'm guessing the upstream bots get their "echo" from msys/Git. In Chromium we use "echo" etc. from GnuWin, and that's what I have locally too.
Maybe the best fix would be to make lit's internal "echo" work both in the pipe and redirect-to-file cases? That way we'd reduce our reliance on external tools, which seems like a good thing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111072/new/
https://reviews.llvm.org/D111072
More information about the llvm-commits
mailing list