[PATCH] D111145: [AArch64][SVE] Propagate math flags from intrinsics to instructions

Matt Devereau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 5 06:44:44 PDT 2021


MattDevereau added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:713
                                                          IntrinsicInst &II) {
+  auto *OpPredicate = II.getOperand(0);
   auto BinOpCode = intrinsicIDToBinOpCode(II.getIntrinsicID());
----------------
david-arm wrote:
> nit: I'm not sure where the additional cosmetic code changes came from? It looks like you only really need to add the `setFastMathFlags` line?
we had a short discussion about what looks better and might be easier to read, debug and work with. its a simple change if you disagree


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111145/new/

https://reviews.llvm.org/D111145



More information about the llvm-commits mailing list