[PATCH] D111057: [fir] Add external name interop pass

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/include/flang/Optimizer/Transforms/Passes.td:27
+    "fir::FIROpsDialect", "mlir::LLVM::LLVMDialect",
+    "mlir::acc::OpenACCDialect", "mlir::omp::OpenMPDialect"
+  ];
----------------
mehdi_amini wrote:
> Can you clarify why are these all needed?
> 
> I would think that no dependent dialect is needed at all here. 
> (do you have a failing test if you remove them?)
I guess this was a mistake on our side and we were thinking we needed to add "allowed" dialects here but it indeed not needed and I'll update the patch to remove these extra dependencies. 


================
Comment at: flang/include/flang/Optimizer/Transforms/Passes.td:40
-  }];
-  let constructor = "fir::createControlFlowLoweringPass()";
-}
----------------
mehdi_amini wrote:
> This method still exists in the header.
> (same for the others)
Right I forgot to clean the header as well. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111057/new/

https://reviews.llvm.org/D111057