[PATCH] D111057: [fir] Add external name interop pass

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: flang/include/flang/Optimizer/Transforms/Passes.td:27
+    "fir::FIROpsDialect", "mlir::LLVM::LLVMDialect",
+    "mlir::acc::OpenACCDialect", "mlir::omp::OpenMPDialect"
+  ];
----------------
Can you clarify why are these all needed?

I would think that no dependent dialect is needed at all here. 
(do you have a failing test if you remove them?)


================
Comment at: flang/include/flang/Optimizer/Transforms/Passes.td:40
-  }];
-  let constructor = "fir::createControlFlowLoweringPass()";
-}
----------------
This method still exists in the header.
(same for the others)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111057/new/

https://reviews.llvm.org/D111057