[PATCH] D110784: Manually create unique_ptr in various pass adaptors

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D110784#3040708 <https://reviews.llvm.org/D110784#3040708>, @dblaikie wrote:

> "83M -> 73M" is peak RAM usage during compilation, I guess?
>
> Is that worth the code changes? I think there's value in make_unique making it easier to read code/check for memory leaks, etc. (makes explicit new stand out more/get extra scrutiny when reading code)

That's compile time, specifically the "instructions" stat in `perf stat` (I should have specified more clearly in the description).
PassBuilder.cpp is by far the longest file to compile (if you only build X86). With many cores/distributed build farms, it's the bottleneck. So yeah I think it's worth it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110784/new/

https://reviews.llvm.org/D110784