[PATCH] D110784: Manually create unique_ptr in various pass adaptors
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 4 12:05:54 PDT 2021
dblaikie added a comment.
"83M -> 73M" is peak RAM usage during compilation, I guess?
Is that worth the code changes? I think there's value in make_unique making it easier to read code/check for memory leaks, etc. (makes explicit new stand out more/get extra scrutiny when reading code)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110784/new/
https://reviews.llvm.org/D110784
More information about the llvm-commits
mailing list