[PATCH] D110848: [TwoAddressInstruction] Fix ReplacedAllUntiedUses in processTiedPairs

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 4 11:36:35 PDT 2021


foad added a comment.

In D110848#3040368 <https://reviews.llvm.org/D110848#3040368>, @MatzeB wrote:

> Have you considered .mir tests instead of .ll tests? They should be more robust as they allow you to test a single pass independently of anything happening before/afterwards.

Yes I considered it, but I think there are advantages to both approaches. The problem with a MIR test case is that if the target changes its instruction definitions in any way, updating the MIR **input** is definitely a manual process.

That said, I'm happy to do a MIR test instead if you still prefer it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110848/new/

https://reviews.llvm.org/D110848



More information about the llvm-commits mailing list