[llvm] 8692d07 - [llvm-objdump] Fix common symbol output on 32 bit platforms

[David Spickett via llvm-commits]

Author: David Spickett
Date: 2021-10-04T14:24:03Z
New Revision: 8692d07e5811ac61459578cb1f23e2e285ea2b0d

URL: https://github.com/llvm/llvm-project/commit/8692d07e5811ac61459578cb1f23e2e285ea2b0d
DIFF: https://github.com/llvm/llvm-project/commit/8692d07e5811ac61459578cb1f23e2e285ea2b0d.diff

LOG: [llvm-objdump] Fix common symbol output on 32 bit platforms

Since https://reviews.llvm.org/D109452 symbol-table.test has
been failing on our Arm32 bots.

https://lab.llvm.org/buildbot/#/builders/171/builds/4201

This is because in that change an implicit widening cast
of the alignment from 32 bit to 64 bit was removed and the
format string expects a 64 bit number.

Added: 
    

Modified: 
    llvm/tools/llvm-objdump/llvm-objdump.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-objdump/llvm-objdump.cpp b/llvm/tools/llvm-objdump/llvm-objdump.cpp
index 32c04bd294e32..3c1ff2977c21c 100644
--- a/llvm/tools/llvm-objdump/llvm-objdump.cpp
+++ b/llvm/tools/llvm-objdump/llvm-objdump.cpp
@@ -2092,7 +2092,7 @@ void objdump::printSymbol(const ObjectFile *O, const SymbolRef &Symbol,
   }
 
   if (Common)
-    outs() << '\t' << format(Fmt, Symbol.getAlignment());
+    outs() << '\t' << format(Fmt, static_cast<uint64_t>(Symbol.getAlignment()));
   else if (O->isXCOFF())
     outs() << '\t'
            << format(Fmt, dyn_cast<const XCOFFObjectFile>(O)->getSymbolSize(