[PATCH] D111048: [ARM] Introduce a MQPRCopy

[Sam Tebbs via Phabricator via llvm-commits]

samtebbs added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:1055
   // in NonPredicated have been found to be a reduction that we can ensure its
-  // legality.
-  for (auto *MI : LiveOutMIs) {
-    if (NonPredicated.count(MI) && FalseLanesUnknown.contains(MI)) {
-      LLVM_DEBUG(dbgs() << "  Unable to handle live out: " << *MI);
-      return false;
+  // legality. Any MQPRCopy found will need to valid its input as if it was
+  // live out.
----------------
valid -> validate


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:1057
+  // live out.
+  SmallPtrSet<MachineInstr *, 2> ExtraLiveOutMIs = LiveOutMIs;
+  while (!ExtraLiveOutMIs.empty()) {
----------------
Rather than re-creating the live out list, would it be possible to do this MQPRCopy checking when constructing the live out list initially, or is the full list of liveouts needed before doing this checking for MQPRCopy instances?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111048/new/

https://reviews.llvm.org/D111048