[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

Sun Oct 3 10:51:54 PDT 2021

xbolva00 added a subscriber: aaron.ballman.
xbolva00 added a comment.

In D110668#3036361 <https://reviews.llvm.org/D110668#3036361>, @thakis wrote:

> In D110668#3034576 <https://reviews.llvm.org/D110668#3034576>, @xbolva00 wrote:
>
>> Please next time give a bit more time to potential reviewers / other folks outside your org. The whole lifecycle of this patch (posted - landed) took < 24h.
>
> Is there anything wrong with the patch?
>
> I agree that it's good to let larger changes sit for a bit, but this seems like a fairly small and inconsequential change to me. Many patches land with a review time < 24h.
>
> In any case, happy to address post-commit review comments too of course.

I think I would prefer to implement such "mapping" in DiagnosticGroups.td instead of current solution. cc @aaron.ballman as well, as he is an exprienced reviewer here.

What I mean,  for example:

  def UnusedParameter : DiagGroup<"unused-parameter", 4100>;

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110668/new/

https://reviews.llvm.org/D110668