[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

Fri Oct 1 06:25:57 PDT 2021

thakis added a comment.

In D110668#3034576 <https://reviews.llvm.org/D110668#3034576>, @xbolva00 wrote:

> Please next time give a bit more time to potential reviewers / other folks outside your org. The whole lifecycle of this patch (posted - landed) took < 24h.

Is there anything wrong with the patch?

I agree that it's good to let larger changes sit for a bit, but this seems like a fairly small and inconsequential change to me. Many patches land with a review time < 24h.

In any case, happy to address post-commit review comments too of course.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110668/new/

https://reviews.llvm.org/D110668