[PATCH] D109837: cmake: Remove config.guess

Sat Oct 2 14:15:59 PDT 2021

aaronpuchert added a comment.

In D109837#3034457 <https://reviews.llvm.org/D109837#3034457>, @tstellar wrote:

> I've been doing a lot of testing with this patch, and one problem I've run into is that config.guess would include -gnu in the environment component of the  triple, where gcc -dumpmachine does not (at least for the redhat triples e.g. x86_64-redhat-linux).  There are a few places in gcc and clang that behave differently when the gnu environment is part of the triple.

Same problem for SUSE. Maybe we could let `Triple::Triple(const Twine &)` "guess" the environment as it does for some MIPS triples? So it would take `x86_64-redhat-linux` but then based on the OS vendor would set `Environment = Triple::GNU;` at least in the case of RedHat and SUSE, and maybe some other OS vendors.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109837/new/

https://reviews.llvm.org/D109837