[PATCH] D109837: cmake: Remove config.guess

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 30 15:46:28 PDT 2021


tstellar added a comment.

In D109837#3034457 <https://reviews.llvm.org/D109837#3034457>, @tstellar wrote:

> I've been doing a lot of testing with this patch, and one problem I've run into is that config.guess would include -gnu in the environment component of the  triple, where gcc -dumpmachine does not (at least for the redhat triples e.g. x86_64-redhat-linux).  There are a few places in gcc and clang that behave differently when the gnu environment is part of the triple.
>
> I wonder if we should normalize some of the gcc style triples to include the gnu environment by default?

I tested this and it doesn't work.  If we normalize x86_64-redhat-linux to x86_64-redhat-linux-gnu, then we don't end up picking the gcc install at /usr/lib/gcc/x86_64-redhat-linux/.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109837/new/

https://reviews.llvm.org/D109837



More information about the llvm-commits mailing list