[PATCH] D110829: [X86] Copy registers in reverse order in convertToThreeAddress

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

>> I don't know if it's safe to rely on the kill flag being on the first operand that uses a particular reg. If not I'll rework the patch.
>
> This seems accidental. I think ideally we would enforce consistency of the flag within an instruction. Short of that we better not assume anything like just the first operand having a kill flag...

That's definitely accidental and I agree it would be best to enforce that the flag is set on all operands within an instruction but this is, like Matthias said, outside of the scope of this PR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110829/new/

https://reviews.llvm.org/D110829