[PATCH] D110747: [NFC] Restore magic and magicu to a globally visible location

[Christopher Tetreault via Phabricator via llvm-commits]

ctetreau added inline comments.


================
Comment at: llvm/include/llvm/Support/DivisionByConstantInfo.h:1
+//== llvm/Support/DivisonByConstantInfo.h - division by constant -*- C++ -*-==//
+//
----------------
foad wrote:
> Just a nit: do we need "Info" in the name? It seems odd in the filename, and I'm not even sure we need it in the struct names either.
It's a bit verbose I agree, but I think it's a (barring abbreviations) minimally descriptive name. It's information about a division by a constant, not a division by a constant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110747/new/

https://reviews.llvm.org/D110747