[PATCH] D110747: [NFC] Restore magic and magicu to a globally visible location

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 30 02:15:56 PDT 2021


foad added inline comments.


================
Comment at: llvm/include/llvm/Support/DivisionByConstantInfo.h:1
+//== llvm/Support/DivisonByConstantInfo.h - division by constant -*- C++ -*-==//
+//
----------------
Just a nit: do we need "Info" in the name? It seems odd in the filename, and I'm not even sure we need it in the struct names either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110747/new/

https://reviews.llvm.org/D110747



More information about the llvm-commits mailing list