[PATCH] D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s))

[Nimish Mishra via Phabricator via llvm-commits]

NimishMishra marked 7 inline comments as done.
NimishMishra added a comment.

Thanks a lot @kiranchandramohan and @peixin for suggestions on the patch.



================
Comment at: flang/lib/Semantics/check-directive-structure.h:148
   D currentDirective_;
+  int numDoConstruct; // tracks number of DoConstruct found AFTER encountering
+                      // an OpenMP/OpenACC directive
----------------
kiranchandramohan wrote:
> Nit: An underscore at the end to match others?
Yes will add that.


================
Comment at: flang/test/Semantics/omp-simd01.f90:27
+   end do
+   !$omp end simd
+10 stop
----------------
kiranchandramohan wrote:
> Nit: Are these ">" format characters. Can you check?
I used fprettify (https://github.com/pseewald/fprettify) to format the test cases. So yes this is indentation added by the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108904/new/

https://reviews.llvm.org/D108904