[PATCH] D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s))

Thu Sep 30 09:34:12 PDT 2021

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks @NimishMishra for this patch, and addressing all the comments, and for your patience.

I have two Nits. Please have a look, fix if necessary and you can submit. You might have to trim the commit message.

================
Comment at: flang/lib/Semantics/check-directive-structure.h:148
   D currentDirective_;
+  int numDoConstruct; // tracks number of DoConstruct found AFTER encountering
+                      // an OpenMP/OpenACC directive
----------------
Nit: An underscore at the end to match others?

================
Comment at: flang/test/Semantics/omp-simd01.f90:27
+   end do
+   !$omp end simd
+10 stop
----------------
Nit: Are these ">" format characters. Can you check?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108904/new/

https://reviews.llvm.org/D108904