[PATCH] D108795: [PowerPC] Fix issue with lowering byval parameters.

[Amy Kwan via Phabricator via llvm-commits]

amyk added a comment.

Thank you for answering my questions! For now, I have some additional nit comments regarding the comments you added.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:4223
+// |-------- 2 bytes --------|---- 1 byte ----|
+// and we want to store the 1 byte element we would call this funciton
+// with the Offset = 2 (as we want to jump over the first 2 bytes.)
----------------



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:4240
+  Arg = DAG.getNode(ISD::ADD, dl, ArgOff.getValueType(), Arg, ArgOff);
+  // Generate a shift to mode the element of interest to the front.
+  SDValue SHRAmt = DAG.getConstant(Offset * 8, dl, MVT::i64);
----------------
Do you mean:


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108795/new/

https://reviews.llvm.org/D108795