[PATCH] D109359: [TableGen] Emit a warning for unused template args

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 30 06:44:51 PDT 2021


c-rhodes updated this revision to Diff 376181.
c-rhodes retitled this revision from "[TableGen] Optionally emit a warning for unused template args" to "[TableGen] Emit a warning for unused template args".
c-rhodes edited the summary of this revision.
c-rhodes added a comment.
Herald added a subscriber: mgorny.

I built all projects that use TableGen (llvm clang, libc, lld, lldb, mlir) for all targets and apart from the Sparc warnings in LLVM that are outstanding (D109712 <https://reviews.llvm.org/D109712>) I only found 2 warnings in MLIR, which are addressed in D110805 <https://reviews.llvm.org/D110805>. Once these outstanding warnings are addressed I think this can be enabled for the whole ecosystem, so I've updated the patch to enable flag for LLVM and sub-projects, if `LLVM_ENABLE_WARNINGS=On`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109359/new/

https://reviews.llvm.org/D109359

Files:
  llvm/cmake/modules/TableGen.cmake
  llvm/include/llvm/TableGen/Record.h
  llvm/lib/TableGen/Main.cpp
  llvm/lib/TableGen/Record.cpp
  llvm/lib/TableGen/TGParser.cpp
  llvm/lib/TableGen/TGParser.h
  llvm/test/TableGen/warn-unused-template-arg.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109359.376181.patch
Type: text/x-patch
Size: 6124 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210930/439ea29f/attachment.bin>


More information about the llvm-commits mailing list