[PATCH] D110652: [fir] Update fir.extract_value and fir.insert_value ops

[Valentin Clement via Phabricator via llvm-commits]

clementval marked an inline comment as done.
clementval added inline comments.


================
Comment at: flang/include/flang/Optimizer/Dialect/FIROps.td:2229
 
 def fir_InsertValueOp : fir_OneResultOp<"insert_value", [NoSideEffect]> {
   let summary = "insert a new sub-value into a copy of an existing aggregate";
----------------
kiranchandramohan wrote:
> Not probably for this patch, but I think we can use TypesMatch for adt and dst.
Right. I'll keep a note on this and we can make a patch later. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110652/new/

https://reviews.llvm.org/D110652